Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[24.0] Check various preconditions in FeatureLocationIndexDataProvider #18283

Merged
merged 1 commit into from
May 31, 2024
Merged

[24.0] Check various preconditions in FeatureLocationIndexDataProvider #18283

merged 1 commit into from
May 31, 2024

Conversation

davelopez
Copy link
Contributor

Fixes #18277

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

mvdbeek
mvdbeek approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you!

@mvdbeek mvdbeek merged commit 10f9b3a into galaxyproject:release_24.0 May 31, 2024
50 checks passed
@davelopez davelopez deleted the 24.0_fix_feature_location_index_data_provider branch June 1, 2024 08:21
@jdavcs jdavcs added this to the 24.1 milestone Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvdbeek mvdbeek mvdbeek approved these changes

Assignees
No one assigned
Labels
area/visualizations kind/bug
Projects
None yet
Milestone
24.1
Development

Successfully merging this pull request may close these issues.
3 participants
@davelopez @mvdbeek @jdavcs